apps/ccusage/src/data-loader.ts (1)

1135-1139: Add a Windows-specific regression test for this glob path fix.

Line 1139 is the right functional fix, but this path bug is platform-specific and easy to regress. Please add an in-source test that simulates Windows-style paths (including a drive-letter-like base path) and asserts loadSessionUsageById resolves and reads the file successfully.

As per coding guidelines, "Write tests in-source using if (import.meta.vitest != null) blocks instead of separate test files".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/ccusage/src/data-loader.ts` around lines 1135 - 1139, Add an in-source
Vitest block to prevent regression of the Windows-path glob fix: inside
apps/ccusage/src/data-loader.ts add an if (import.meta.vitest != null) test that
stubs claudePaths to contain a Windows-style base (e.g., "C:\\some\\base") and a
mocked filesystem where a projects/**/<sessionId>.jsonl file exists; call
loadSessionUsageById with that sessionId and assert it resolves and returns the
expected content. Ensure the test exercises the
path.join(...).replace(/\\/g,'/') behavior (so it uses the same code path that
builds patterns) and uses a temporary/mock glob or fs stub to avoid real IO;
reference the functions/variables loadSessionUsageById and claudePaths/patterns
to locate where to hook the test.

apps/ccusage/src/data-loader.ts (1)

1621-1629: Good regression test for pattern normalization, but consider adding a note about the absolute: true fix.

This test validates the backslash-to-forward-slash normalization, which is essential for tinyglobby compatibility on Windows. However, it doesn't directly test the primary fix ({absolute: true} option) that prevents malformed relative paths when session files are on a different disk.

Consider adding a brief comment to document that this test covers the pattern normalization aspect, while the {absolute: true} option (tested implicitly by the integration tests above) handles the cross-disk absolute path requirement.

📝 Suggested documentation enhancement

-		it('builds glob patterns with forward slashes from Windows-style drive-letter paths', () => {
+		// Regression test: Pattern normalization for tinyglobby on Windows.
+		// The `{absolute: true}` option in loadSessionUsageById handles cross-disk path resolution.
+		it('builds glob patterns with forward slashes from Windows-style drive-letter paths', () => {
 			const windowsBase = 'C:\\Users\\test\\.claude';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/ccusage/src/data-loader.ts` around lines 1621 - 1629, Add a short inline
comment in the test "builds glob patterns with forward slashes from
Windows-style drive-letter paths" (the spec that reproduces the pattern-building
logic used by loadSessionUsageById) clarifying that this unit test verifies path
separator normalization for tinyglobby, and that the separate fix using the
{absolute: true} option (applied where loadSessionUsageById builds the glob) is
responsible for ensuring absolute paths across drives and is covered by the
integration tests; reference the test name and the loadSessionUsageById pattern
construction so future readers know which code handles normalization vs.
cross-disk absolute path behavior.

apps/ccusage/src/data-loader.ts (1)

1139-1140: Good fix for Windows cross-drive path handling.

Adding { absolute: true } aligns this glob call with the other two usages in this file (lines 719-722 and 1364-1367) and correctly fixes the Windows issue where relative paths would produce malformed combined paths.

Minor formatting nit: Consider adding spaces inside the object literal for consistency with the rest of the codebase (e.g., line 721 uses { cwd: claudeDir, absolute: true }).

♻️ Optional formatting fix

-	const jsonlFiles = await glob(patterns, {absolute: true});
+	const jsonlFiles = await glob(patterns, { absolute: true });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/ccusage/src/data-loader.ts` around lines 1139 - 1140, The glob call
creating jsonlFiles uses an object literal without spaces; update the call to
glob(patterns, { absolute: true }) for consistency with other usages (see other
calls around glob(..., { cwd: claudeDir, absolute: true }) ) so the option
remains absolute: true while matching project formatting; ensure you only change
the spacing inside the object literal for the symbol jsonlFiles/glob.